Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the iCKB bot to be CCC-native, replacing Lumos-based dependencies with the CCC framework and updating the README and package configuration accordingly. It introduces a new rebalancing policy and modularizes the state management and transaction building logic. A critical issue was identified in the cell collection logic where an incorrect filter configuration would prevent the bot from discovering capacity cells, potentially halting its operation.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request migrates the iCKB bot to a CCC-native architecture, replacing Lumos dependencies with @ckb-ccc/core and internal @ickb packages. The bot's core logic in index.ts has been refactored to utilize the new SDK, and a new rebalancing policy has been implemented with unit tests. Additionally, a bug in the OrderMatcher was fixed where incorrect scale factors were used for UDT-to-CKB orders, and new checks for matchability and minimum match requirements were added. I have no feedback to provide.
|
LGTM Phroi %115 |
1 participant
Why
Changes
apps/botaroundIckbSdk,OrderManager,LogicManager, andOwnedOwnerManagerwhile keeping app-local signing, fee completion, send, and rebalance policy